src: use OnScopeLeave instead of multiple free() - #44852
Merged
nodejs-github-bot merged 1 commit intoOct 3, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is not great either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
cjihrig
approved these changes
Oct 1, 2022
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The indentation of the ToLocal() on line 1002 looks a little odd, but LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
@cjihrig Agreed, but the new-ish format-cpp linter requires this change :/ |
Sorry, something went wrong.
daeyeon
approved these changes
Oct 2, 2022
RaisinTen
approved these changes
Oct 2, 2022
jasnell
approved these changes
Oct 2, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
16 tasks
19 tasks
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
This is not great either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks. PR-URL: #44852 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not perfect either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks.