FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x backport] WPT runner update and crypto followups by panva · Pull Request #44872 · nodejs/node · GitHub

/ node Public

[v16.x backport] WPT runner update and crypto followups - #44872

Closed
panva wants to merge 0 commit into
nodejs:v16.x-stagingfrom
panva:backport-lots-to-v16.x
ConversationCommits (0)ChecksFiles changed
Closed

[v16.x backport] WPT runner update and crypto followups#44872
panva wants to merge 0 commit into
nodejs:v16.x-stagingfrom
panva:backport-lots-to-v16.x

Conversation

panva commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022

nodejs-github-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Oct 3, 2022
panva force-pushed the backport-lots-to-v16.x branch from da76d2f to 55bf5cd Compare October 3, 2022 09:13
panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Oct 3, 2022
panva marked this pull request as ready for review October 3, 2022 09:14

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

lint failures unrelated to the changes in this PR

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

cc @juanarbol @daeyeon

daeyeon commented Oct 3, 2022

Copy link
Copy Markdown
Member

@panva Thanks for this backporting.

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

Also cc @nodejs/backporters, didn't mean to step on anyone's toes here. Since I've not done backporting before, I followed doc/contributing/backporting-to-release-lines.md for every single commit except I've added them all into a single branch and PR.

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2022

This comment was marked as outdated.

Sign in to view

panva commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI failures are most likely present on v16.x-staging as well (both lint and test.parallel/test-net-socket-*)

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Oct 4, 2022
Open
16 tasks

panva commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

nodejs-github-bot commented Oct 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47087/

panva commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

The CI results are the same as for the v16.x proposal / staged changes. When those are resolved this is good to re-run and land.

nodejs-github-bot commented Oct 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47094/

github-actions Bot mentioned this pull request Oct 6, 2022
Open
25 tasks

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47096/

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47107/

github-actions Bot mentioned this pull request Oct 7, 2022
Open
20 tasks
panva force-pushed the backport-lots-to-v16.x branch from b758f43 to 1805fe0 Compare October 7, 2022 17:56
github-actions Bot mentioned this pull request Oct 8, 2022
Open
20 tasks
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
test: update WPT runner
6648459 
PR-URL: nodejs#43455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Backport-PR-URL: nodejs#44872
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
crypto: fix webcrypto generateKey() AES key length validation error
272503f 
PR-URL: nodejs#44170
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44872
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
crypto: fix webcrypto operation errors to be OperationError
af8eb95 
PR-URL: nodejs#44171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44872
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
crypto: fix webcrypto EC key namedCurve validation errors
3003a81 
PR-URL: nodejs#44172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44872

nodejs-github-bot commented Oct 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47129/

github-actions Bot mentioned this pull request Oct 9, 2022
Open
18 tasks

nodejs-github-bot commented Oct 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47134/

This was referenced Oct 10, 2022
Open
Open

juanarbol commented Oct 11, 2022

Copy link
Copy Markdown
Member

Landed in bc20e470d7...54b96355cf 🎉 💚

Muchas gracias!

github-actions Bot mentioned this pull request Oct 12, 2022
Open
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL