| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
|
Changes to upstream dependencies need to be made in the appropriate respective repositories instead of this repository. |
Sorry, something went wrong.
|
Following up to what @mscdex said, here are their relevant repositories/sources so you can contribute the proposed changes easily: The proposed changes to the deps directory must be forwarded to their respective repositories/sources instead, shown in the following: base64: https://github.com/aklomp/base64 The proposed changes to the test/fixtures/wpt directory must be forwarded to https://github.com/web-platform-tests/wpt The proposed changes to the tools/node_modules/eslint directory must be forwarded to https://github.com/eslint/eslint Although your change to the test/parallel directory is correct, you may want to either remove the other changes and leave that one only, or open a new PR. |
Sorry, something went wrong.
|
Sorry, I somehow missed the part of the contribution guide about the dependencies. 🤦♂️ I have reverted all the upstream changes and this PR is now only changing test/parallel directory. |
Sorry, something went wrong.
|
I would recommend changing the commit message title to start with test: instead of src: since this change only affect the test directory. |
Sorry, something went wrong.
|
Also be sure to remove the merge commit and rebase the other commits on top of your branch instead of adding them manually, only the latest commit is needed. |
Sorry, something went wrong.
|
@VoltrexMaster I have updated the commit message and rebased but I'm not sure if that's what you have requested. If not then please advice me on what to do here. |
Sorry, something went wrong.
Not what I actually requested, you should use an interactive rebase to drop the older commits and only keep the latest commit (with it's commit message edited to reflect the message of this PR), and instead of merging the upstream changes on your fork to be up-to-date you should pull the upstream changes and rebase by just running git pull --rebase upstream main. |
Sorry, something went wrong.
|
Landed in 84044df, thanks for the contribution 🎉 |
Sorry, something went wrong.
`succesfully` -> `successfully` PR-URL: #44882 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`succesfully` -> `successfully` PR-URL: #44882 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`succesfully` -> `successfully` PR-URL: #44882 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`succesfully` -> `successfully` PR-URL: #44882 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
| Back | FazBrowse Home | New Git URL |
Fixed typos around the codebase, mostly in comments.