crypto: add causes to applicable webcrypto's OperationError - #44890
Merged
nodejs-github-bot merged 1 commit intoOct 10, 2022
Merged
crypto: add causes to applicable webcrypto's OperationError#44890nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
lpinca
approved these changes
Oct 4, 2022
This comment was marked as outdated.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
reviewed
Oct 5, 2022
anonrig
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
This was referenced Oct 6, 2022
aduh95
approved these changes
Oct 10, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44890 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #44703, adding the underlying error as cause to WebCryptoAPI DOMExceptions.