doc,crypto: mark experimental algorithms more visually - #44892
Merged
nodejs-github-bot merged 1 commit intoOct 6, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I pulled these changes in and used a tool to check the resulting HTML for accessibility-related color contrast issues and there weren't any. 👍 Looks good to me. |
Sorry, something went wrong.
panva
marked this pull request as ready for review
October 5, 2022 12:01
panva
force-pushed
the
webcrypto-api-experimental
branch
from
6534dee to
b9d74e0
Compare
October 5, 2022 12:01
panva
force-pushed
the
webcrypto-api-experimental
branch
from
b9d74e0 to
555466e
Compare
October 5, 2022 12:11
aymen94
approved these changes
Oct 5, 2022
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
lpinca
approved these changes
Oct 5, 2022
Trott
approved these changes
Oct 6, 2022
Copy link
Copy Markdown
Member
|
FYI for @nodejs/website @nodejs/nodejs-dev in case these kinds of things might affect the website in ways I'm not aware of. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
For nodejs.dev this change would not create any issues afaik. |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44892 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #44588 this adds a Stability index color-coded indicator to experimental WebCryptoAPI algorithms' documentation.
🖼️ Dark mode - table