lib: require JSDoc in internal validators code - #44896
Merged
Trott merged 1 commit intoOct 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
reviewed
Oct 5, 2022
anonrig
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks great!
Sorry, something went wrong.
himself65
approved these changes
Oct 5, 2022
lpinca
approved these changes
Oct 6, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44896 ✔ Done loading data for nodejs/node/pull/44896 ----------------------------------- PR info ------------------------------------ Title lib: require JSDoc in internal validators code (#44896) Author Rich Trott (@Trott) Branch Trott:validator -> nodejs:main Labels author ready, needs-ci Commits 1 - lib: require JSDoc in internal validators code Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/44896 Fixes: https://github.com/nodejs/node/issues/44893 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44896 Fixes: https://github.com/nodejs/node/issues/44893 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - lib: require JSDoc in internal validators code ℹ This PR was created on Wed, 05 Oct 2022 03:09:30 GMT ✔ Approvals: 2 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/44896#pullrequestreview-1132028270 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44896#pullrequestreview-1133531828 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-06T21:27:58Z: https://ci.nodejs.org/job/node-test-pull-request/47109/ - Querying data for job/node-test-pull-request/47109/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3205068185 |
Sorry, something went wrong.
Closes: nodejs#44893 PR-URL: nodejs#44896 Fixes: nodejs#44893 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #44893