FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: move release keys we don't use anymore in README by Trott · Pull Request #44899 · nodejs/node · GitHub

/ node Public

doc: move release keys we don't use anymore in README - #44899

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
Trott:releasers
Oct 7, 2022
ConversationCommits (2)ChecksFiles changed
Merged

doc: move release keys we don't use anymore in README#44899
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
Trott:releasers

Conversation

Trott commented Oct 6, 2022

Copy link
Copy Markdown
Member

Trott commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

@nodejs/releasers

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 6, 2022
Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed doc Issues and PRs related to the documentations. labels Oct 6, 2022

github-actions Bot commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott added a commit to nodejs/docker-node that referenced this pull request Oct 6, 2022
chore: remove keys for emeritus releasers
7264cd2 
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/node#44899
Trott mentioned this pull request Oct 6, 2022
Merged
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44899
✔  Done loading data for nodejs/node/pull/44899
----------------------------------- PR info ------------------------------------
Title      doc: move release keys we don't use anymore in README (#44899)
Author     Rich Trott  (@Trott)
Branch     Trott:releasers -> nodejs:main
Labels     fast-track
Commits    2
 - doc: move release keys we don't use anymore in README
 - fixup! doc: move release keys we don't use anymore in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Oct 2022 00:23:20 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3200609475

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 6, 2022
Trott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 6, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 6, 2022

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44899
✔  Done loading data for nodejs/node/pull/44899
----------------------------------- PR info ------------------------------------
Title      doc: move release keys we don't use anymore in README (#44899)
Author     Rich Trott  (@Trott)
Branch     Trott:releasers -> nodejs:main
Labels     fast-track, commit-queue-squash
Commits    2
 - doc: move release keys we don't use anymore in README
 - fixup! doc: move release keys we don't use anymore in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Oct 2022 00:23:20 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3200661575

Trott removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 6, 2022
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
nodejs-github-bot merged commit 24d255f into nodejs:main Oct 7, 2022

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 24d255f

Trott deleted the releasers branch October 7, 2022 13:26
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
doc: move release keys we don't use anymore in README
b6b9c42 
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784
PR-URL: #44899
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
danielleadams mentioned this pull request Oct 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
marsonya marsonya approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL