[v16.x backport] tools: refactor avoid-prototype-pollution lint rule - #44926
Closed
aduh95 wants to merge 3 commits into
Closed
[v16.x backport] tools: refactor avoid-prototype-pollution lint rule#44926aduh95 wants to merge 3 commits into
aduh95 wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
18 tasks
MoLow
approved these changes
Oct 10, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
force-pushed
the
v16.x-staging
branch
from
02cd9a9 to
54b9635
Compare
October 10, 2022 23:49
15 tasks
aduh95
force-pushed
the
backport-avoid-prototype-pollution
branch
from
871d33d to
b87d6d3
Compare
October 11, 2022 03:45
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@juanarbol In case it's not to late / not too much work to integrate this in the 16.18.0 proposal, I think this can land :) (if it's not convenient for you to add it, no worries, it's not urgent at all). |
Sorry, something went wrong.
juanarbol
force-pushed
the
v16.x-staging
branch
from
54b9635 to
18e1766
Compare
October 11, 2022 19:46
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: #43476 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #44446 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
aduh95
force-pushed
the
backport-avoid-prototype-pollution
branch
from
b87d6d3 to
f8364c5
Compare
October 11, 2022 20:16
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
richardlau
approved these changes
Nov 23, 2022
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Refs: nodejs/node#43475 Backport-PR-URL: nodejs/node#44926 PR-URL: nodejs/node#43475
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: nodejs/node#43476 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#44446 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Refs: nodejs/node#43475 Backport-PR-URL: nodejs/node#44926 PR-URL: nodejs/node#43475
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: nodejs/node#43476 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#44446 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of:
268f662 e5594dc24d48a52402ac7ca2b02b299305c9cc64 is a continuation of #43475, it looks like it was missed in #44081.