test_runner: add extra fields in AssertionError YAML - #44952
Merged
nodejs-github-bot merged 1 commit intoOct 26, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bengl
force-pushed
the
bengl/expected-actual
branch
from
75c6a05 to
669a977
Compare
October 10, 2022 19:40
MoLow
approved these changes
Oct 10, 2022
Copy link
Copy Markdown
Member
|
FYI @manekinekko let's make sure this addition is compatible with #43525 after it lands |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yep, should be easy to add these fields here |
Sorry, something went wrong.
jasnell
approved these changes
Oct 16, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes.
bengl
force-pushed
the
bengl/expected-actual
branch
from
669a977 to
6f09e43
Compare
October 25, 2022 01:11
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44952 ✔ Done loading data for nodejs/node/pull/44952 ----------------------------------- PR info ------------------------------------ Title test_runner: add extra fields in AssertionError YAML (#44952) Author Bryan English (@bengl) Branch bengl:bengl/expected-actual -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: add extra fields in AssertionError YAML Committers 1 - Bryan English PR-URL: https://github.com/nodejs/node/pull/44952 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44952 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test_runner: add extra fields in AssertionError YAML ℹ This PR was created on Mon, 10 Oct 2022 19:30:45 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44952#pullrequestreview-1136519381 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44952#pullrequestreview-1143346750 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-25T12:38:51Z: https://ci.nodejs.org/job/node-test-pull-request/47465/ - Querying data for job/node-test-pull-request/47465/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3325742811 |
Sorry, something went wrong.
MoLow
approved these changes
Oct 26, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Dec 9, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many TAP reporters offer special-case handling of YAML objects containing expected, actual, and operator fields, as produced by AssertionError and similar userland Error classes.