test: improve assertions in test-repl-unsupported-option.js - #44953
Merged
nodejs-github-bot merged 1 commit intoOct 18, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Oct 10, 2022
JungMinu
approved these changes
Oct 11, 2022
cola119
approved these changes
Oct 11, 2022
cola119
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
BridgeAR
approved these changes
Oct 11, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I noticed lib/internal/main/repl.jsL33-L38 is not covered at some point 🤔 |
Sorry, something went wrong.
cjihrig
approved these changes
Oct 11, 2022
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM if the CI is happy.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44953 ✔ Done loading data for nodejs/node/pull/44953 ----------------------------------- PR info ------------------------------------ Title test: improve assertions in `test-repl-unsupported-option.js` (#44953) Author Juan José (@juanarbol) Branch juanarbol:juan/endurance-asserts-repl-test -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: improve assertions in `test-repl-unsupported-option.js` Committers 1 - Juan José Arboleda PR-URL: https://github.com/nodejs/node/pull/44953 Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung Reviewed-By: Kohei Ueno Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44953 Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung Reviewed-By: Kohei Ueno Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 10 Oct 2022 19:31:20 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44953#pullrequestreview-1136460634 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/44953#pullrequestreview-1136738208 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138243493 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138244930 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138255796 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-10-11T22:59:31Z: https://ci.nodejs.org/job/node-test-pull-request/47199/ - Querying data for job/node-test-pull-request/47199/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3252094696 |
Sorry, something went wrong.
anonrig
approved these changes
Oct 14, 2022
jasnell
approved these changes
Oct 16, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44953 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.