FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add test to improve coverage in test-http2-compat-serverresponse-write.js by Cesar-M-Diaz · Pull Request #44970 · nodejs/node · GitHub

/ node Public

test: add test to improve coverage in test-http2-compat-serverresponse-write.js - #44970

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Cesar-M-Diaz:test-fix-1
Oct 14, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: add test to improve coverage in test-http2-compat-serverresponse-write.js#44970
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Cesar-M-Diaz:test-fix-1

Conversation

Cesar-M-Diaz commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Added a test to complement the test coverage on this file test-http2-compat-serverresponse-write.js

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 11, 2022
juanarbol approved these changes Oct 11, 2022
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lpinca reviewed Oct 11, 2022
View reviewed changes
Comment thread test/parallel/test-http2-compat-serverresponse-write.js Outdated

lpinca Oct 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are both this and client.destroy(); below needed? I would keep only one if possible.

Cesar-M-Diaz Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think is not necessary, just pushed a new commit for that. Thanks

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2022

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47224/

juanarbol commented Oct 13, 2022

Copy link
Copy Markdown
Member

CI failing is not related to this change. Requesting a CI run again

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2022

nodejs-github-bot commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47268/

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47271/

edsadr approved these changes Oct 14, 2022
View reviewed changes

edsadr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Cesar-M-Diaz commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

@lpinca PTAL

lpinca commented Oct 14, 2022

Copy link
Copy Markdown
Member

@Cesar-M-Diaz it seems good to me but I'm not sure I understand what is tested in particular. Can you please add a comment or clarify how coverage is increased with a link or an image? Thanks.

Cesar-M-Diaz commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

@lpinca Im covering this statement with the test

lpinca commented Oct 14, 2022

Copy link
Copy Markdown
Member

Thanks.

juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2022
nodejs-github-bot merged commit 4264b19 into nodejs:main Oct 14, 2022

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4264b19

This was referenced Oct 18, 2022
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
test: add test to improve coverage in http2-compat-serverresponse
1e67dda 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
test: add test to improve coverage in http2-compat-serverresponse
ea0cfc9 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
test: add test to improve coverage in http2-compat-serverresponse
45ad2cc 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
test: add test to improve coverage in http2-compat-serverresponse
6e3227b 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
edsadr edsadr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL