FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: add options to the heap snapshot APIs by joyeecheung · Pull Request #44989 · nodejs/node · GitHub

/ node Public

lib: add options to the heap snapshot APIs - #44989

Closed
joyeecheung wants to merge 5 commits into
nodejs:mainfrom
joyeecheung:heapsnapshot-options
ConversationCommits (5)ChecksFiles changed
Closed

lib: add options to the heap snapshot APIs#44989
joyeecheung wants to merge 5 commits into
nodejs:mainfrom
joyeecheung:heapsnapshot-options

Conversation

joyeecheung commented Oct 13, 2022

Copy link
Copy Markdown
Member

Support configuration of the HeapSnapshotMode and NumericsMode fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 13, 2022
joyeecheung commented Oct 13, 2022
View reviewed changes
Comment thread doc/api/v8.md Outdated

joyeecheung Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am actually not sure if we should use constants (e.g. strings) for these, suggestions are welcome. Also AFAIK exposeInternals doesn't currently change anything for us because we don't use any embedder tracing mechanism provided by V8 that could would make a difference here, but this might change in the future.

joyeecheung commented Oct 13, 2022
View reviewed changes
Comment thread doc/api/worker_threads.md Outdated
Comment thread doc/api/v8.md Outdated
Comment thread doc/api/v8.md Outdated
aduh95 reviewed Oct 13, 2022
View reviewed changes
Comment thread lib/internal/heap_utils.js Outdated
aduh95 reviewed Oct 13, 2022
View reviewed changes
Comment thread lib/internal/worker.js Outdated
jasnell reviewed Oct 16, 2022
View reviewed changes
Comment thread doc/api/v8.md Outdated
jasnell reviewed Oct 16, 2022
View reviewed changes
Comment thread doc/api/v8.md Outdated
jasnell reviewed Oct 16, 2022
View reviewed changes
Comment thread doc/api/v8.md Outdated
jasnell reviewed Oct 16, 2022
View reviewed changes
Comment thread doc/api/worker_threads.md Outdated
jasnell reviewed Oct 16, 2022
View reviewed changes
Comment thread lib/internal/heap_utils.js Outdated
lib: add options to the heap snapshot APIs
df587a0 
Support configuration of the HeapSnapshotMode and NumericsMode
fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.
fixup! lib: add options to the heap snapshot APIs
cbe5987

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47594/

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47595/

github-actions Bot mentioned this pull request Nov 1, 2022
Open
17 tasks

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47614/

joyeecheung commented Nov 1, 2022
View reviewed changes
Comment thread lib/internal/heap_utils.js
const {
exposeInternals = false,
exposeNumericValues = false,
} = options;

joyeecheung Nov 1, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated to use destructuring + default values because assignment doesn't work with kEmtpyObject. @jasnell @aduh95

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47618/

github-actions Bot mentioned this pull request Nov 2, 2022
Open
15 tasks

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47766/

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47773/

github-actions Bot mentioned this pull request Nov 8, 2022
Open
17 tasks
joyeecheung added a commit that referenced this pull request Nov 8, 2022
lib: add options to the heap snapshot APIs
b872d30 
Support configuration of the HeapSnapshotMode and NumericsMode
fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.

PR-URL: #44989
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

joyeecheung commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

Landed in b872d30

joyeecheung closed this Nov 8, 2022
github-actions Bot mentioned this pull request Nov 9, 2022
Open
14 tasks
github-actions Bot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
lib: add options to the heap snapshot APIs
0478e40 
Support configuration of the HeapSnapshotMode and NumericsMode
fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.

PR-URL: #44989
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS mentioned this pull request Nov 10, 2022
Merged
github-actions Bot mentioned this pull request Nov 11, 2022
Open
19 tasks

danielleadams commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

@joyeecheung this broke when landing in v18.x-staging. Do you mind opening a backport PR for this?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
aduh95 aduh95 left review comments
addaleax addaleax approved these changes
legendecas legendecas approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL