FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: add initial blob benchmark by anonrig · Pull Request #44990 · nodejs/node · GitHub

/ node Public

benchmark: add initial blob benchmark - #44990

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
anonrig:perf/blob-benchmark
Oct 17, 2022
ConversationCommits (3)ChecksFiles changed
Merged

benchmark: add initial blob benchmark#44990
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
anonrig:perf/blob-benchmark

Conversation

anonrig commented Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Following the performance pull request, I opened, this pull request only includes the benchmark.

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Oct 13, 2022
anonrig mentioned this pull request Oct 13, 2022
Closed

aduh95 commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

Can you add a test similar to test/benchmark/test-benchmark-streams.js please?

aduh95 requested a review from BridgeAR October 13, 2022 14:38

anonrig commented Oct 13, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review @aduh95. I added the test file.

BridgeAR reviewed Oct 13, 2022
View reviewed changes
Comment thread benchmark/blob/blob.js Outdated
anonrig requested a review from BridgeAR October 17, 2022 07:11
anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 17, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2022

nodejs-github-bot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47290/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 17, 2022

nodejs-github-bot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44990
✔  Done loading data for nodejs/node/pull/44990
----------------------------------- PR info ------------------------------------
Title      benchmark: add initial blob benchmark (#44990)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:perf/blob-benchmark -> nodejs:main
Labels     benchmark, author ready
Commits    3
 - benchmark: add blob benchmark
 - test: add blob benchmark
 - benchmark: update blob byte values
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/44990
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44990
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 13 Oct 2022 13:49:07 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44990#pullrequestreview-1141406993
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44990#pullrequestreview-1143345652
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/44990#pullrequestreview-1143745210
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-17T07:29:37Z: https://ci.nodejs.org/job/node-test-pull-request/47290/
- Querying data for job/node-test-pull-request/47290/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 44990
From https://github.com/nodejs/node
 * branch                  refs/pull/44990/merge -> FETCH_HEAD
✔  Fetched commits as b65db88fd2cb..a32f9796c8c0
--------------------------------------------------------------------------------
[main 5fab374e51] benchmark: add blob benchmark
 Author: Yagiz Nizipli 
 Date: Thu Oct 13 16:48:36 2022 +0300
 1 file changed, 30 insertions(+)
 create mode 100644 benchmark/blob/blob.js
[main b0b7240cd5] test: add blob benchmark
 Author: Yagiz Nizipli 
 Date: Thu Oct 13 17:48:19 2022 +0300
 1 file changed, 7 insertions(+)
 create mode 100644 test/benchmark/test-benchmark-blob.js
[main c9e7768dcf] benchmark: update blob byte values
 Author: Yagiz Nizipli 
 Date: Thu Oct 13 18:16:41 2022 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

benchmark: add blob benchmark


PR-URL: #44990

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com

Reviewed-By: Ruben Bridgewater ruben@bridgewater.de


[detached HEAD b0aa80d444] benchmark: add blob benchmark

Author: Yagiz Nizipli yagiz@nizipli.com

Date: Thu Oct 13 16:48:36 2022 +0300

1 file changed, 30 insertions(+)

create mode 100644 benchmark/blob/blob.js

Rebasing (3/6)

Rebasing (4/6)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: add blob benchmark


PR-URL: #44990

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com

Reviewed-By: Ruben Bridgewater ruben@bridgewater.de


[detached HEAD e130166767] test: add blob benchmark

Author: Yagiz Nizipli yagiz@nizipli.com

Date: Thu Oct 13 17:48:19 2022 +0300

1 file changed, 7 insertions(+)

create mode 100644 test/benchmark/test-benchmark-blob.js

Rebasing (5/6)

Rebasing (6/6)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

benchmark: update blob byte values


PR-URL: #44990

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com

Reviewed-By: Ruben Bridgewater ruben@bridgewater.de


[detached HEAD 22feeff097] benchmark: update blob byte values

Author: Yagiz Nizipli yagiz@nizipli.com

Date: Thu Oct 13 18:16:41 2022 +0300

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/3264440711

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 17, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2022
nodejs-github-bot merged commit 6adaf23 into nodejs:main Oct 17, 2022

nodejs-github-bot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Landed in 6adaf23

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
benchmark: add blob benchmark
1a58b7c 
PR-URL: #44990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
benchmark: add blob benchmark
a27c994 
PR-URL: #44990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
benchmark: add blob benchmark
9a4fab9 
PR-URL: #44990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
benchmark: add blob benchmark
1ed312a 
PR-URL: #44990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL