build: restore Windows resource file - #45042
Merged
nodejs-github-bot merged 1 commit intoOct 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add back the Windows resource file to the build scripts that was mistakenly removed by aa3a572.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
approved these changes
Oct 17, 2022
Copy link
Copy Markdown
Member
Author
|
Does anyone know if the stuff in https://github.com/nodejs/node/blob/main/src/res/node.rc (which is missing from Windows builds prior to this PR) is critical enough that this needs to land in v19.0.0 as opposed to waiting for the next patch/minor version? (I suspect it's a bit late to make it into Node.js 19.0.0). cc @nodejs/releasers |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
Oct 17, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Oct 17, 2022
RafaelGSS
approved these changes
Oct 17, 2022
13 tasks
gengjiawen
approved these changes
Oct 18, 2022
VoltrexKeyva
approved these changes
Oct 18, 2022
RaisinTen
approved these changes
Oct 18, 2022
15 tasks
This was referenced Oct 20, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
Add back the Windows resource file to the build scripts that was mistakenly removed by aa3a572. PR-URL: #45042 Fixes: #45025 Refs: #43652 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Add back the Windows resource file to the build scripts that was mistakenly removed by aa3a572. PR-URL: #45042 Fixes: #45025 Refs: #43652 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back the Windows resource file to the build scripts that was mistakenly removed by aa3a572.
Fixes: #45025
Refs: #43652
cc @nodejs/platform-windows @nodejs/build-files