test: remove unnecessary noop function args to mustCall() - #45047
Merged
nodejs-github-bot merged 1 commit intoOct 20, 2022
Merged
test: remove unnecessary noop function args to mustCall()#45047nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
approved these changes
Oct 18, 2022
anonrig
approved these changes
Oct 18, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RaisinTen
approved these changes
Oct 18, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45047 ✔ Done loading data for nodejs/node/pull/45047 ----------------------------------- PR info ------------------------------------ Title test: remove unnecessary noop function args to `mustCall()` (#45047) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:noop -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: remove unnecessary noop function args to `mustCall()` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/45047 Reviewed-By: Rich Trott Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45047 Reviewed-By: Rich Trott Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Oct 2022 03:00:33 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45047#pullrequestreview-1145033188 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45047#pullrequestreview-1145441759 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45047#pullrequestreview-1145897919 ✖ This PR needs to wait 35 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-18T12:21:00Z: https://ci.nodejs.org/job/node-test-pull-request/47318/ - Querying data for job/node-test-pull-request/47318/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3274898631 |
Sorry, something went wrong.
jasnell
approved these changes
Oct 18, 2022
himself65
approved these changes
Oct 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #45027, which the first commit is from. Marking this PR as blocked PRs that are blocked by other issues or PRs. until the other PR lands.