FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix test runner coverage by MoLow · Pull Request #45055 · nodejs/node · GitHub

/ node Public

src: fix test runner coverage - #45055

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-coverage
Oct 20, 2022
ConversationCommits (1)ChecksFiles changed
Merged

src: fix test runner coverage#45055
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-coverage

Conversation

MoLow commented Oct 18, 2022

Copy link
Copy Markdown
Member

Fixes: #45013

MoLow requested a review from cjihrig October 18, 2022 14:44
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Oct 18, 2022
MoLow added coverage Issues and PRs related to native coverage support. test_runner Issues and PRs related to the test runner subsystem. dont-land-on-v14.x labels Oct 18, 2022
cjihrig approved these changes Oct 18, 2022
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

MoLow force-pushed the fix-test-runner-coverage branch 2 times, most recently from 1f7f85e to 4e7b6d2 Compare October 18, 2022 16:07
MoLow force-pushed the fix-test-runner-coverage branch from 4e7b6d2 to e4f6b97 Compare October 18, 2022 18:26
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47331/

MoLow added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 20, 2022
MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
nodejs-github-bot merged commit 54eb543 into nodejs:main Oct 20, 2022

nodejs-github-bot commented Oct 20, 2022

Copy link
Copy Markdown
Collaborator

Landed in 54eb543

MoLow deleted the fix-test-runner-coverage branch October 20, 2022 18:21
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
src: fix test runner coverage
9186f50 
PR-URL: #45055
Fixes: #45013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
src: fix test runner coverage
162bf0d 
PR-URL: #45055
Fixes: #45013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow mentioned this pull request Nov 24, 2022
Closed

iambumblehead commented Nov 30, 2022

Copy link
Copy Markdown

Politely, it would be great if this were found in the stable 18.* series. After porting many tests to use the node native test runner, one must use unstable 19.* to continue getting test coverage

iambumblehead commented Nov 30, 2022

Copy link
Copy Markdown

installing the 19.* series and running the tests, the test process continues when tests have failed

MoLow commented Nov 30, 2022

Copy link
Copy Markdown
Member Author

node 18 is in the LTS phase so it will be receiving these commits

MoLow added a commit to MoLow/node that referenced this pull request Dec 9, 2022
src: fix test runner coverage
16b7b2b 
PR-URL: nodejs#45055
Fixes: nodejs#45013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
w3nl mentioned this pull request Dec 20, 2022
Closed
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
src: fix test runner coverage
b2bd879 
PR-URL: #45055
Fixes: #45013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
src: fix test runner coverage
57b7023 
PR-URL: #45055
Fixes: #45013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
laurentsenta mentioned this pull request Mar 7, 2023
Open
MoLow mentioned this pull request Mar 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. coverage Issues and PRs related to native coverage support. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests are not running anymore with C8 on node 18.11

6 participants

Back | FazBrowse Home | New Git URL