src: clarify OptionEnvvarSettings member names - #45057
Merged
nodejs-github-bot merged 1 commit intoOct 27, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
legendecas
force-pushed
the
env-options
branch
from
a5806ba to
1563488
Compare
October 18, 2022 17:24
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
approved these changes
Oct 18, 2022
Copy link
Copy Markdown
Member
|
@nodejs/cpp-reviewers |
Sorry, something went wrong.
RaisinTen
approved these changes
Oct 20, 2022
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The current name sounds better but one comment
Sorry, something went wrong.
Comment thread
src/node.h
Outdated
legendecas
force-pushed
the
env-options
branch
from
f1ea7e2 to
8dfba84
Compare
October 23, 2022 16:32
joyeecheung
approved these changes
Oct 24, 2022
Comment thread
src/node.h
Outdated
legendecas
force-pushed
the
env-options
branch
from
8dfba84 to
ef5ac63
Compare
October 24, 2022 16:38
Copy link
Copy Markdown
Member
Author
|
It came to me that embedders can actually parse the args from environment variables other than NODE_OPTIONS with the embedder API ProcessGlobalArgs. So I reverted the name to kAllowedInEnvvar and kDisallowedInEnvvar and documented these members and the API ProcessGlobalArgs. |
Sorry, something went wrong.
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved.
legendecas
force-pushed
the
env-options
branch
from
ef5ac63 to
cb039c2
Compare
October 24, 2022 16:42
RafaelGSS
approved these changes
Oct 24, 2022
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
addaleax
approved these changes
Oct 25, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: #45057 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: #45057 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Contributor
|
@legendecas this broke the build when landing in v18.x. Do you mind creating a backport? Thank you. |
Sorry, something went wrong.
This was referenced Jan 24, 2023
legendecas
added a commit
to legendecas/node
that referenced
this pull request
May 18, 2023
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: nodejs#45057 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
May 29, 2023
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: #45057 Backport-PR-URL: #45994 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: nodejs#45057 Backport-PR-URL: nodejs#45994 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term Environment in kAllowedInEnvironment and
kDisallowedInEnvironment has nothing to do with the commonly used
term node::Environment. Rename the member to kAllowedInEnvvar and
kDisallowedInEnvvar respectively to reflect they are options of
OptionEnvvarSettings.
As OptionEnvvarSettings is part of the public embedder APIs, the
legacy names are still preserved.