lib: add lint rule to protect against Object.prototype.then pollution - #45061
Merged
nodejs-github-bot merged 1 commit intoOct 21, 2022
Merged
lib: add lint rule to protect against Object.prototype.then pollution#45061nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ljharb
reviewed
Oct 19, 2022
Comment thread
lib/internal/webstreams/readablestream.js
JakobJingleheimer
approved these changes
Oct 19, 2022
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Huzzah, thanks!
Sorry, something went wrong.
MoLow
approved these changes
Oct 19, 2022
JungMinu
approved these changes
Oct 19, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Oct 19, 2022
aduh95
force-pushed
the
lint-object-then
branch
from
feb4e23 to
fe474c0
Compare
October 19, 2022 22:07
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
10 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
11 tasks
anonrig
approved these changes
Oct 21, 2022
This was referenced Oct 22, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45061 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45061 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @MoLow in #45044 (review).