FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

net: remove _readableState from debug statement by Trott · Pull Request #45063 · nodejs/node · GitHub

/ node Public

net: remove _readableState from debug statement - #45063

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Trott:net-readablestream
Oct 21, 2022
ConversationCommits (1)ChecksFiles changed
Merged

net: remove _readableState from debug statement#45063
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Trott:net-readablestream

Conversation

Trott commented Oct 19, 2022

Copy link
Copy Markdown
Member

Ref: #445

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Oct 19, 2022
Trott added the stream Issues and PRs related to the stream subsystem. label Oct 19, 2022

Trott commented Oct 19, 2022

Copy link
Copy Markdown
Member Author

@nodejs/streams

Trott force-pushed the net-readablestream branch from 6007247 to 7bfc179 Compare October 19, 2022 05:07
Trott changed the title net: remove _readableStream from debug statement net: remove _readableState from debug statement Oct 19, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47329/

mcollina approved these changes Oct 19, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 19, 2022
ShogunPanda approved these changes Oct 19, 2022
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

nodejs-github-bot commented Oct 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47353/

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
nodejs-github-bot merged commit b86b1a7 into nodejs:main Oct 21, 2022

nodejs-github-bot commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in b86b1a7

Trott deleted the net-readablestream branch October 21, 2022 22:19
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
net: remove _readableState from debug statement
6c20fa5 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
net: remove _readableState from debug statement
36acf8a 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
net: remove _readableState from debug statement
8cc29a3 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
net: remove _readableState from debug statement
e4f7bcf 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
jasnell jasnell approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL