doc: mention v18.x openssl maintaining guide - #45070
Merged
nodejs-github-bot merged 1 commit intoOct 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
approved these changes
Oct 19, 2022
richardlau
approved these changes
Oct 19, 2022
BethGriggs
approved these changes
Oct 19, 2022
jasnell
approved these changes
Oct 19, 2022
AugustinMauroy
approved these changes
Oct 20, 2022
AugustinMauroy
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM ✨
Sorry, something went wrong.
lpinca
approved these changes
Oct 20, 2022
Copy link
Copy Markdown
Member
|
Is there a typo in commit message? "migration" -> "maintaining". |
Sorry, something went wrong.
mhdawson
approved these changes
Oct 20, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
RafaelGSS
force-pushed
the
doc/maintaining-openssl-v18
branch
from
12c1c01 to
e5b0dcd
Compare
October 21, 2022 12:57
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45070 ✔ Done loading data for nodejs/node/pull/45070 ----------------------------------- PR info ------------------------------------ Title doc: mention v18.x openssl maintaining guide (#45070) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc/maintaining-openssl-v18 -> nodejs:main Labels doc Commits 1 - doc: mention v18.x openssl maintaining guide Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/45070 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Beth Griggs Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45070 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Beth Griggs Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: mention v18.x openssl maintaining guide ℹ This PR was created on Wed, 19 Oct 2022 12:26:25 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1147464514 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1147480751 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1147605979 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1148304898 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45070#pullrequestreview-1149876771 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1150058050 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3298570699 |
Sorry, something went wrong.
richardlau
approved these changes
Oct 21, 2022
RafaelGSS
added a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
RafaelGSS
added a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing really changed. However, it's important to ensure main now refers to the 'Current' release, v19.x.