FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: add recursive watch for linux by anonrig · Pull Request #45098 · nodejs/node · GitHub

/ node Public

fs: add recursive watch for linux - #45098

Merged
nodejs-github-bot merged 38 commits into
nodejs:mainfrom
anonrig:fs/add-recursive-watch
Oct 31, 2022
ConversationCommits (38)ChecksFiles changed
Merged

fs: add recursive watch for linux#45098
nodejs-github-bot merged 38 commits into
nodejs:mainfrom
anonrig:fs/add-recursive-watch

Conversation

anonrig commented Oct 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #36005

List

CC @nodejs/fs

anonrig added fs Issues and PRs related to the fs subsystem / file system. notable-change PRs with changes that should be highlighted in changelogs. labels Oct 20, 2022
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 20, 2022
kibertoad reviewed Oct 20, 2022
View reviewed changes
Comment thread lib/fs.js Outdated
aduh95 reviewed Oct 20, 2022
View reviewed changes
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
aduh95 reviewed Oct 20, 2022
View reviewed changes
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
bnoordhuis reviewed Oct 20, 2022
View reviewed changes
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
cjihrig reviewed Oct 20, 2022
View reviewed changes
Comment thread lib/internal/fs/linux_recursive_watcher.js Outdated
anonrig force-pushed the fs/add-recursive-watch branch from 0c106f0 to 45e8f37 Compare October 21, 2022 18:17
anonrig force-pushed the fs/add-recursive-watch branch 6 times, most recently from 7275124 to a7b310d Compare October 21, 2022 23:24
anonrig marked this pull request as ready for review October 21, 2022 23:30
anonrig force-pushed the fs/add-recursive-watch branch from a7b310d to fd0a954 Compare October 21, 2022 23:46
anonrig requested review from targos and removed request for kibertoad October 21, 2022 23:46
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2022

This comment was marked as outdated.

Sign in to view
aduh95 reviewed Oct 22, 2022
View reviewed changes
Comment thread lib/internal/fs/linux_watcher.js Outdated
Comment thread lib/internal/fs/linux_watcher.js Outdated
Comment thread lib/internal/fs/linux_watcher.js Outdated
mcollina requested changes Oct 22, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This module uses a mix of callbacks and promises. I would prefer if it only relied on callbacks as it would be a callback API. Maybe I'm a bit too concerned about the intertwining of our two sets of APIs.

This also needs support for the promises API.

aduh95 reviewed Oct 22, 2022
View reviewed changes
Comment thread lib/internal/fs/watch/linux.js Outdated
anonrig force-pushed the fs/add-recursive-watch branch from d0f5179 to df1c187 Compare October 22, 2022 21:07
anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 31, 2022

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

Landed in 17ae2ab

github-actions Bot mentioned this pull request Nov 1, 2022
Open
17 tasks

MoLow commented Nov 1, 2022

Copy link
Copy Markdown
Member

@anonrig congratulations 🎉

anonrig mentioned this pull request Nov 1, 2022
Merged
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
MoLow mentioned this pull request Nov 1, 2022
Closed
danielleadams mentioned this pull request Dec 30, 2022
Merged

danielleadams commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

Hi @anonrig - this did not land cleanly on v18.x. When landing there were variables used that were not defined in v18.x-staging branch's version of the file. Could you open a backport PR? Thank you.

anonrig commented Jan 3, 2023

Copy link
Copy Markdown
Member Author

@danielleadams It seems this pull request is in the v18.x-staging branch: https://github.com/nodejs/node/blob/v18.13.0-proposal/lib/internal/fs/recursive_watch.js

torchiaf mentioned this pull request Jan 12, 2023
Closed

juanarbol commented Jan 26, 2023

Copy link
Copy Markdown
Member

@danielleadams It seems this pull request is in the v18.x-staging branch: https://github.com/nodejs/node/blob/v18.13.0-proposal/lib/internal/fs/recursive_watch.js

That link is a 404; marking this is a "backport-requested-v18.x" again.

anonrig commented Jan 26, 2023

Copy link
Copy Markdown
Member Author

This pull request is already backported @juanarbol

Referencing: https://github.com/nodejs/node/blob/v18.x-staging/lib/internal/fs/recursive_watch.js

aduh95 commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

That's not correct @anonrig, the pull request was not backported, it never showed on the v18.x changelog. The file you linked was added with c2f0377 (which is a backport for #45265), but all the other changes in this PR still need to be backported manually (docs and tests).

nascarsayan mentioned this pull request Mar 12, 2023
Closed
schlichtanders mentioned this pull request Oct 9, 2023
Closed

raphaelboukara commented Jan 15, 2024

Copy link
Copy Markdown

Hi :)
Does this fix will be backported to v18.x ?

mcollina commented Jan 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I don't expect this to be backported, because there are issues with this and Node.js v18 is in maintenance.

See #48437 for more details.

arenekosreal mentioned this pull request Feb 18, 2024
Closed
kirjavascript mentioned this pull request Apr 18, 2024
Merged
avivkeller mentioned this pull request Oct 3, 2024
Closed
coderabbitai Bot mentioned this pull request Mar 20, 2026
Merged
3 tasks
coderabbitai Bot mentioned this pull request Mar 31, 2026
Merged
8 tasks
coderabbitai Bot mentioned this pull request Apr 10, 2026
Merged
6 tasks
coderabbitai Bot mentioned this pull request Apr 18, 2026
Merged
coderabbitai Bot mentioned this pull request May 5, 2026
Merged
4 tasks
coderabbitai Bot mentioned this pull request May 12, 2026
Merged
This was referenced Jul 29, 2026
Closed
Merged
aqeelat mentioned this pull request Jul 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
aduh95 aduh95 approved these changes
mcollina mcollina approved these changes
jasnell jasnell approved these changes
MoLow MoLow approved these changes
bnoordhuis Awaiting requested review from bnoordhuis
cjihrig Awaiting requested review from cjihrig
richardlau Awaiting requested review from richardlau
+4 more reviewers
kibertoad kibertoad left review comments
targos targos left review comments
cagataycali cagataycali left review comments
V-for-Vasili V-for-Vasili left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recursive fs.watch for linux
Back | FazBrowse Home | New Git URL