[v14.x backport] tools: add more options to track flaky tests - #45126
Closed
aduh95 wants to merge 2 commits into
Closed
[v14.x backport] tools: add more options to track flaky tests#45126aduh95 wants to merge 2 commits into
aduh95 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Refs: nodejs#43929 (comment) PR-URL: nodejs#43954 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Feng Yu <F3n67u@outlook.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
richardlau
reviewed
Oct 22, 2022
Comment thread
.github/workflows/build-tarball.yml
richardlau
approved these changes
Oct 22, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This will need changes so that it also works with Python 2 if it is to land in v14.x. |
Sorry, something went wrong.
aduh95
commented
Oct 22, 2022
Comment thread
tools/test.py
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
13 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
13 tasks
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/lts can this be merged to unblock nodejs/build#3056 please? |
Sorry, something went wrong.
RafaelGSS
approved these changes
Oct 24, 2022
Merged
mhdawson
approved these changes
Oct 24, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Oct 25, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 26, 2022
Refs: #43929 (comment) PR-URL: #43954 Backport-PR-URL: #45126 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Feng Yu <F3n67u@outlook.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43954, needed for nodejs/build#3056.