http2: fix debugStream method - #45129
Merged
nodejs-github-bot merged 1 commit intoOct 25, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
So it actually logs something when debug is activated.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
approved these changes
Oct 22, 2022
lpinca
approved these changes
Oct 22, 2022
cjihrig
approved these changes
Oct 22, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
13 tasks
Copy link
Copy Markdown
Member
|
The CI failed in macOS w/ ENOSPC error. Kicking ci again |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
approved these changes
Oct 24, 2022
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
16 tasks
This was referenced Oct 26, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it actually logs something when debug is activated.