FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: avoid hiding by navigation bar in anchor jumping by cloydlau · Pull Request #45131 · nodejs/node · GitHub

/ node Public

doc: avoid hiding by navigation bar in anchor jumping - #45131

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cloydlau:main
May 16, 2024
ConversationCommits (1)ChecksFiles changed
Merged

doc: avoid hiding by navigation bar in anchor jumping#45131
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cloydlau:main

Conversation

cloydlau commented Oct 23, 2022 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 23, 2022

mscdex commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Fixes #42286 ?

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 12, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
nodejs-github-bot merged commit b0bd534 into nodejs:main May 16, 2024

nodejs-github-bot commented May 16, 2024

Copy link
Copy Markdown
Collaborator

Landed in b0bd534

targos pushed a commit that referenced this pull request May 21, 2024
doc: avoid hiding by navigation bar in anchor jumping
4c65c52 
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS mentioned this pull request Jun 7, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
doc: avoid hiding by navigation bar in anchor jumping
ed2a511 
PR-URL: nodejs#45131
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ChALkeR commented Jun 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I think that navigating the documentation is significantly broken now

Not sure if it's by this change, or by combination with smooth scrolling, or by any other changes in the doc structure, but navigating 22.x docs just scrolls to incorrect locations

  • 20.x docs work fine (but with minor offset)
  • 22.2.0 docs work fine (but also with a minor offset)
  • 22.3.0 docs scroll to completely wrong locations
  • 22.x docs on github work fine

cloydlau mentioned this pull request Jul 1, 2024
Merged

cloydlau commented Jul 1, 2024

Copy link
Copy Markdown
Contributor Author

@ChALkeR Hello, this PR was proposed on Octobe 2022, at that time Node 22 had not yet been released. It might be caused by scroll-padding-top: 50vh;. Therefore I submitted a PR to fix it.

cloydlau commented Jul 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

However, this issue still exists in the Node 17 documentation. I submitted this PR to specifically address the documentation for Node 17.

cloydlau mentioned this pull request Jul 1, 2024
Closed
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
doc: avoid hiding by navigation bar in anchor jumping
2854585 
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito mentioned this pull request Jul 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: HTML API docs' fixed header obscures anchored content

5 participants

Back | FazBrowse Home | New Git URL