stream: fix duplexify premature destroy - #45133
Closed
ronag wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: nodejs#44925
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Oct 23, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
benjamingr
approved these changes
Oct 23, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
xtx1130
reviewed
Oct 24, 2022
xtx1130
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
In node v16 has the same code here. But why v16 don't have this issue?
Sorry, something went wrong.
jasnell
reviewed
Oct 24, 2022
Comment thread
test/parallel/test-stream-duplex-from.js
Outdated
juanarbol
approved these changes
Oct 24, 2022
16 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 26, 2022
Copy link
Copy Markdown
Member
Author
|
@mcollina what is our procedure to include these kind of PR's in readable-stream? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Once it ship in a version of Node (ideally the 18 series) I can open a PR update. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45133 ✔ Done loading data for nodejs/node/pull/45133 ----------------------------------- PR info ------------------------------------ Title stream: fix duplexify premature destroy (#45133) Author Robert Nagy (@ronag) Branch ronag:fix-44925 -> nodejs:main Labels stream, author ready Commits 2 - stream: fix duplexify premature destroy - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/45133 Fixes: https://github.com/nodejs/node/issues/44925 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Juan José Arboleda ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45133 Fixes: https://github.com/nodejs/node/issues/44925 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Juan José Arboleda -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ℹ This PR was created on Sun, 23 Oct 2022 13:51:44 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45133#pullrequestreview-1152327819 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45133#pullrequestreview-1152332503 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/45133#pullrequestreview-1153558445 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-25T14:51:07Z: https://ci.nodejs.org/job/node-test-pull-request/47472/ - Querying data for job/node-test-pull-request/47472/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3336681891 |
Sorry, something went wrong.
juanarbol
pushed a commit
that referenced
this pull request
Oct 27, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
10 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error.
Fixes: #44925