install: remove unused language files - #45138
Closed
bnoordhuis wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bnoordhuis
force-pushed
the
rm-i18n-msi
branch
from
fcd7e16 to
36de209
Compare
October 23, 2022 22:43
Copy link
Copy Markdown
Member
Author
|
"installer" has definitely been used in the past, silly bot. |
Sorry, something went wrong.
aduh95
approved these changes
Oct 23, 2022
daeyeon
approved these changes
Oct 23, 2022
Copy link
Copy Markdown
Member
If you want to add installer, we'll need to add it to https://github.com/nodejs/core-validate-commit/blob/a3cb753bc1a2d57457959ffd28578c2b44aa93a4/lib/rules/subsystem.js. The installer subsystem hasn't been used in a commit message for over six years, though. It's probably easier to switch the commit message here to build (or tools). |
Sorry, something went wrong.
Trott
approved these changes
Oct 24, 2022
gengjiawen
approved these changes
Oct 24, 2022
jasnell
approved these changes
Oct 24, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: nodejs#45090
bnoordhuis
force-pushed
the
rm-i18n-msi
branch
from
36de209 to
0fa45f9
Compare
October 24, 2022 12:57
Copy link
Copy Markdown
Member
Author
|
I took the path of least resistance and switched to build: |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Oct 24, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
pushed a commit
that referenced
this pull request
Oct 27, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled.
There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either.
Let's remove the files because it was confusing at least one potential contributor.
Refs: #45090