FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update V8 gypfiles for RISC-V by andreas-schwab · Pull Request #45149 · nodejs/node · GitHub

/ node Public

tools: update V8 gypfiles for RISC-V - #45149

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
andreas-schwab:main
Oct 26, 2022
ConversationCommits (1)ChecksFiles changed
Merged

tools: update V8 gypfiles for RISC-V#45149
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
andreas-schwab:main

Conversation

andreas-schwab commented Oct 24, 2022 •
edited by targos
Loading

Copy link
Copy Markdown
Contributor

With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

Fixes #45059

tools: update V8 gypfiles for RISC-V
1637a41 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Oct 24, 2022

richardlau commented Oct 24, 2022

Copy link
Copy Markdown
Member

Fixes #45059 ?

andreas-schwab commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

Yes.

richardlau added the riscv64 Issues and PRs related to the riscv64 architecture. label Oct 24, 2022
gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2022

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47444/

sxa approved these changes Oct 24, 2022
View reviewed changes

sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for this :-)

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 24, 2022
gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 26, 2022

This comment was marked as outdated.

Sign in to view
gengjiawen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 26, 2022
richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
nodejs-github-bot merged commit e888855 into nodejs:main Oct 26, 2022

nodejs-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Landed in e888855

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
tools: update V8 gypfiles for RISC-V
f45dbc8 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
tools: update V8 gypfiles for RISC-V
a415869 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
tools: update V8 gypfiles for RISC-V
1439b34 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
tools: update V8 gypfiles for RISC-V
48cf890 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
F3n67u mentioned this pull request Jan 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
sxa sxa approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the riscv64 architecture. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

riscv64 (unofficial) builds of v19.0.0 failed

8 participants

Back | FazBrowse Home | New Git URL