doc: add link to triage guide - #45154
Merged
nodejs-github-bot merged 1 commit intoOct 26, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
F3n67u
approved these changes
Oct 25, 2022
Trott
approved these changes
Oct 25, 2022
VoltrexKeyva
approved these changes
Oct 26, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45154
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
at consumeBody (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Response.text (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
at async Request.json (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
at async Request.query (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
at async Request.queryAll (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
at async Request.gql (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
at async PRData.getComments (file:///opt/hostedtoolcache/node/18.12.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
at async Promise.all (index 2)
at async Promise.all (index 1) {
type: 'system',
errno: 'ERR_STREAM_PREMATURE_CLOSE',
code: 'ERR_STREAM_PREMATURE_CLOSE',
erroredSysCall: undefined
}https://github.com/nodejs/node/actions/runs/3329941567
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45154 ✔ Done loading data for nodejs/node/pull/45154 ----------------------------------- PR info ------------------------------------ Title doc: add link to triage guide (#45154) Author Brian Muenzenmeyer (@bmuenzenmeyer) Branch bmuenzenmeyer:main -> nodejs:main Labels doc, author ready, commit-queue-failed Commits 1 - doc: add link to triage guide Committers 1 - Brian Muenzenmeyer PR-URL: https://github.com/nodejs/node/pull/45154 Reviewed-By: Feng Yu Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45154 Reviewed-By: Feng Yu Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 24 Oct 2022 23:04:13 GMT ✔ Approvals: 3 ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/45154#pullrequestreview-1154650626 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45154#pullrequestreview-1155686189 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/45154#pullrequestreview-1156624227 ✖ This PR needs to wait 5 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3331250122 |
Sorry, something went wrong.
jasnell
approved these changes
Oct 26, 2022
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45154 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45154 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45154 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45154 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm interested in helping out more within the Node.js project on the heels of GHC Open Source Day mentoring.
In researching the landscape a bit, I determined that the triage role (PR for that forthcoming...) would be a great place to start, but it took me a while to find the triage guidance from README ➡️ GOVERNANCE ➡️ .doc/contributing/issues
This PR makes a direct reference to the triage guide, emulating the pattern of the collaborator guide in the previous section.