buffer: fix validation of options in Blob constructor - #45156
Merged
aduh95 merged 5 commits intoOct 31, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
it might be worth linking to the webidl spec https://webidl.spec.whatwg.org/#es-dictionary (it also helps to understand which values are allowed) |
Sorry, something went wrong.
joyeecheung
reviewed
Oct 25, 2022
Comment thread
lib/internal/validators.js
aduh95
commented
Oct 27, 2022
aduh95
commented
Oct 27, 2022
Comment thread
lib/internal/validators.js
Outdated
anonrig
approved these changes
Oct 31, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
reviewed
Oct 31, 2022
Comment thread
lib/internal/validators.js
joyeecheung
approved these changes
Oct 31, 2022
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
17 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45156 Refs: https://webidl.spec.whatwg.org/#es-dictionary Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
This was referenced Nov 2, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45156 Refs: https://webidl.spec.whatwg.org/#es-dictionary Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45156 Refs: https://webidl.spec.whatwg.org/#es-dictionary Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45156 Refs: https://webidl.spec.whatwg.org/#es-dictionary Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align more Node.js Blob implementations with other runtimes (I've tested the behavior on Firefox, Safari, Chromium, and Deno).
Refs: https://webidl.spec.whatwg.org/#es-dictionary