test_runner: call {before,after}Each() on suites - #45161
Merged
nodejs-github-bot merged 1 commit intoOct 27, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that. Fixes: nodejs#45028
MoLow
approved these changes
Oct 25, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Oct 25, 2022
jasnell
approved these changes
Oct 26, 2022
Merged
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Dec 9, 2022
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that. Fixes: nodejs#45028 PR-URL: nodejs#45161 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that. Fixes: nodejs/node#45028 PR-URL: nodejs/node#45161 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that. Fixes: nodejs/node#45028 PR-URL: nodejs/node#45161 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that. Fixes: nodejs/node#45028 PR-URL: nodejs/node#45161 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that. Fixes: nodejs/node#45028 PR-URL: nodejs/node#45161 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that.
Fixes: #45028