build: workaround for node-core-utils - #45199
Merged
nodejs-github-bot merged 1 commit intoOct 28, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
Sorry, something went wrong.
aduh95
reviewed
Oct 27, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Maybe change the value of NODE_VERSION instead? Otherwise it's pretty confusing:
node/.github/workflows/auto-start-ci.yml
Lines 13 to 14 in 5e2aeae
Sorry, something went wrong.
gengjiawen
force-pushed
the
fix/node_fetch_fix
branch
from
637cb28 to
cf6bc87
Compare
October 27, 2022 03:38
aduh95
approved these changes
Oct 27, 2022
richardlau
approved these changes
Oct 27, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45199 ✔ Done loading data for nodejs/node/pull/45199 ----------------------------------- PR info ------------------------------------ Title build: workaround for node-core-utils (#45199) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:fix/node_fetch_fix -> nodejs:main Labels meta, fast-track Commits 1 - build: workaround for node-core-utils Committers 1 - Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/45199 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45199 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 27 Oct 2022 03:34:38 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45199#pullrequestreview-1157558430 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45199#pullrequestreview-1158015502 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3336617372 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I wonder if a better workaround would be to set NODE_OPTIONS to --dns-result-order=ipv4first since that seems to be what's the causing the issue according to the linked issue. |
Sorry, something went wrong.
anonrig
approved these changes
Oct 27, 2022
juanarbol
approved these changes
Oct 27, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45199 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45199 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45199 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45199 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: nodejs/node-core-utils#653 (comment)