FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lock-free init_process_flags for all archs by kapouer · Pull Request #45221 · nodejs/node · GitHub

/ node Public

lock-free init_process_flags for all archs - #45221

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kapouer:patch-4
Oct 31, 2022
ConversationCommits (1)ChecksFiles changed
Merged

lock-free init_process_flags for all archs#45221
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kapouer:patch-4

Conversation

kapouer commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

Fix #45152

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2022
addaleax reviewed Oct 28, 2022
View reviewed changes
Comment thread src/node.cc Outdated
addaleax requested changes Oct 28, 2022
View reviewed changes
Comment thread src/node.h Outdated
Comment thread src/node.cc Outdated
kapouer force-pushed the patch-4 branch 2 times, most recently from 2fc42b0 to 1627557 Compare October 28, 2022 13:19
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022

This comment was marked as outdated.

Sign in to view

kapouer commented Oct 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@addaleax changed TODO(addaleax) and wrapped line to 80 chars.

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
This was referenced Oct 29, 2022
Open
Open
Open

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47593/

Flarna added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 31, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022
nodejs-github-bot merged commit 3d1bdc9 into nodejs:main Oct 31, 2022

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

Landed in 3d1bdc9

github-actions Bot mentioned this pull request Nov 1, 2022
Open
17 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
src: lock-free init_process_flags
db81931 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
github-actions Bot mentioned this pull request Nov 2, 2022
Open
15 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
src: lock-free init_process_flags
97547bc 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
src: lock-free init_process_flags
8247d10 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
src: lock-free init_process_flags
bf028a6 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
addaleax mentioned this pull request Jan 30, 2023
Merged
addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2023
src: use uint32_t for process initialization flags enum
f3cffbd 
Refs: nodejs#45221
nodejs-github-bot pushed a commit that referenced this pull request Feb 2, 2023
src: use uint32_t for process initialization flags enum
f84de0a 
Refs: #45221
PR-URL: #46427
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
juanarbol juanarbol approved these changes
Flarna Flarna approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

init_process_flags.is_lock_free check fails on mipsel

5 participants

Back | FazBrowse Home | New Git URL