tools: add GitHub token permissions to label flaky-test issues - #45308
tools: add GitHub token permissions to label flaky-test issues#45308nodejs-github-bot merged 1 commit into
Conversation
Sorry, something went wrong.
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
|
Review requested:
|
Sorry, something went wrong.
|
Is read permission actually enough for labelling issues? That seems quite counter intuitive to me. |
Sorry, something went wrong.
No, you are right, it is not. The permission that allows labelling the issues is issues: write inside the job in line 12 of the unchanged file. The contents: read permission before the job is to avoid this job and other jobs from "by default" being able to access the contents of the repository. Access to the contents of the repository means being able to create files, delete files, among other things. |
Sorry, something went wrong.
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add minimum GITHUB_TOKEN permissions for label-flaky-test-issue.yml workflow.
Motivation: Setting minimum permissions on workflow's top level is good practice. Similar changes were previously discussed in #43743. Since label flaky-test issues workflow was recently added, this PR is a small update to restrict it's permissions.
About me: I'm Gabriela and I work on behalf of Google and the OpenSSF suggesting supply-chain security changes :)
Signed-off-by: Gabriela Gutierrez gabigutierrez@google.com