FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v14.x backport] http2: fix memory leak when nghttp2 hd threshold is reached by ywave620 · Pull Request #45310 · nodejs/node · GitHub

/ node Public

[v14.x backport] http2: fix memory leak when nghttp2 hd threshold is reached - #45310

Closed
ywave620 wants to merge 2 commits into
nodejs:v14.x-stagingfrom
ywave620:v14.x-staging-h2-large-hdr-fix
ConversationCommits (2)ChecksFiles changed
Closed

[v14.x backport] http2: fix memory leak when nghttp2 hd threshold is reached#45310
ywave620 wants to merge 2 commits into
nodejs:v14.x-stagingfrom
ywave620:v14.x-staging-h2-large-hdr-fix

Conversation

ywave620 commented Nov 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport #41502 to v14
Address #45295

nodejs-github-bot commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v14.x labels Nov 4, 2022
http2: fix memory leak on nghttp2 hd threshold
2291969 
PR-URL: nodejs#41502
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022

nodejs-github-bot commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47692/

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47705/

RafaelGSS approved these changes Nov 5, 2022
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

ywave620 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

@RafaelGSS Would you mind merging this?

RafaelGSS commented Nov 14, 2022

Copy link
Copy Markdown
Member

@RafaelGSS Would you mind merging this?

The next releaser will merge it when performing the release. I believe the date will show up here nodejs/Release#567

ywave620 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

The next releaser will merge it when performing the release. I believe the date will show up here nodejs/Release#567

Okay. Thanks for the information :)

richardlau pushed a commit that referenced this pull request Nov 23, 2022
http2: fix memory leak when nghttp2 hd threshold is reached
c3a90c4 
Refs: #45295
PR-URL: #41502
Backport-PR-URL: #45310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

richardlau commented Nov 23, 2022

Copy link
Copy Markdown
Member

Landed in c3a90c4.

richardlau closed this Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL