FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: revert is_release to 0 by RafaelGSS · Pull Request #45315 · nodejs/node · GitHub

/ node Public

src: revert is_release to 0 - #45315

Closed
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix/revert-node-release
ConversationCommits (1)ChecksFiles changed
Closed

src: revert is_release to 0#45315
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix/revert-node-release

Conversation

RafaelGSS commented Nov 4, 2022

Copy link
Copy Markdown
Member

It was wrongly committed on the v19.0.1 release.

RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 4, 2022
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 4, 2022

github-actions Bot commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

juanarbol approved these changes Nov 4, 2022
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022

nodejs-github-bot commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47689/

anonrig commented Nov 4, 2022

Copy link
Copy Markdown
Member

@nodejs/tsc Can we merge this without waiting for CI? It affects all new pull requests.

BethGriggs commented Nov 4, 2022

Copy link
Copy Markdown
Member

https://github.com/orgs/nodejs/teams/tsc Can we merge this without waiting for CI? It affects all new pull requests.

+1, we should as it'll cause failures elsewhere without it.

mhdawson approved these changes Nov 4, 2022
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented Nov 4, 2022

Copy link
Copy Markdown
Member

+1 from me as well to merge

mhdawson commented Nov 4, 2022

Copy link
Copy Markdown
Member

But of course not with the squash and merge. I assume it will need to be landed manually.

anonrig pushed a commit that referenced this pull request Nov 4, 2022
src: revert is_release to 0
7124476 
PR-URL: #45315
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

anonrig commented Nov 4, 2022

Copy link
Copy Markdown
Member

Landed in 7124476

anonrig closed this Nov 4, 2022
This was referenced Nov 4, 2022
Closed
Closed
This was referenced Nov 6, 2022
Open
Open
Open
RafaelGSS added a commit that referenced this pull request Nov 10, 2022
src: revert is_release to 0
4e45585 
PR-URL: #45315
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS mentioned this pull request Nov 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
anonrig anonrig approved these changes
richardlau richardlau approved these changes
juanarbol juanarbol approved these changes
+2 more reviewers
danielleadams danielleadams approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL