FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip test-fs-largefile if not enough disk space by Trott · Pull Request #45339 · nodejs/node · GitHub

/ node Public

test: skip test-fs-largefile if not enough disk space - #45339

Merged
Trott merged 1 commit into
nodejs:mainfrom
Trott:fix-fs
Nov 7, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: skip test-fs-largefile if not enough disk space#45339
Trott merged 1 commit into
nodejs:mainfrom
Trott:fix-fs

Conversation

Trott commented Nov 6, 2022

Copy link
Copy Markdown
Member

Fixes: nodejs/build#3071

I'm guessing this is the test that then causes other cascading disk failures, but maybe there are others. Let's run CI here and find out....

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2022
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47736/

Trott commented Nov 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

My Jenkins CI didn't run out of space so I'm running just the macOS part of it again. I want to see that the test is actually skipped when ENOSPC happens. https://ci.nodejs.org/job/node-test-commit-osx/48467/

EDIT: And another one. https://ci.nodejs.org/job/node-test-commit-osx/48469/

EDIT: And one more. https://ci.nodejs.org/job/node-test-commit-osx/48470/

Trott commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

Here's another one: https://ci.nodejs.org/job/node-test-commit-osx/48483/

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47751/

github-actions Bot mentioned this pull request Nov 7, 2022
Open
18 tasks

Trott commented Nov 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Hooray, it caught a failure that time!

https://ci.nodejs.org/job/node-test-commit-osx/48483/nodes=osx1015/console

I think this is ready for review and landing.

@anonrig @nodejs/testing

anonrig approved these changes Nov 7, 2022
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perfect! Thanks @Trott. Can you apply the same changes to other tests too?

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 7, 2022
anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 7, 2022

github-actions Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2022

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T00:01:32Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3412750367

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 7, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2022

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T17:54:35Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3412750367

test: skip test-fs-largefile if not enough disk space
e080331 
Fixes: nodejs/build#3071

PR-URL: nodejs#45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Trott merged commit e080331 into nodejs:main Nov 7, 2022

Trott commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

Landed in e080331

Trott deleted the fix-fs branch November 7, 2022 19:13
github-actions Bot mentioned this pull request Nov 8, 2022
Open
17 tasks
github-actions Bot mentioned this pull request Nov 9, 2022
Open
14 tasks
github-actions Bot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
test: skip test-fs-largefile if not enough disk space
717db1d 
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
RafaelGSS mentioned this pull request Nov 10, 2022
Merged
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
test: skip test-fs-largefile if not enough disk space
50358f1 
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
test: skip test-fs-largefile if not enough disk space
7e0332a 
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
+1 more reviewer
Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No space left on device OSX 1015

4 participants

Back | FazBrowse Home | New Git URL