deps: V8: cherry-pick 56816d76c121 - #45353
Merged
nodejs-github-bot merged 1 commit intoNov 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Original commit message:
[loong64] Supplement a LoongArch support in include/v8config.h
Change-Id: I658c1b781163bcd3ca39bfceb74aef9d255247b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3894795
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Liu Yu <liuyu@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#83374}
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
approved these changes
Nov 7, 2022
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gengjiawen
approved these changes
Nov 7, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
14 tasks
20 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Original commit message:
[loong64] Supplement a LoongArch support in include/v8config.h
Change-Id: I658c1b781163bcd3ca39bfceb74aef9d255247b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3894795
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Liu Yu <liuyu@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#83374}
PR-URL: #45353
Refs: v8/v8@56816d7
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
19 tasks
Copy link
Copy Markdown
Contributor
|
@shipujin does this need to go into v18? If so, this needs a backport PR - thank you. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
v18 doesn't need it, it only appears in v19
Danielle Adams ***@***.***> 于 2022年12月5日周一 上午10:01写道：
… @shipujin <https://github.com/shipujin> does this need to go into v18? If
so, this needs a backport PR - thank you.
—
Reply to this email directly, view it on GitHub
<#45353 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNWOCRCCTMCOQSLWKZW77DWLVEJDANCNFSM6AAAAAARYX56IA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
[loong64] Supplement a LoongArch support in include/v8config.h Change-Id: I658c1b781163bcd3ca39bfceb74aef9d255247b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3894795 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Liu Yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#83374}Refs: v8/v8@56816d7