FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools,test: enable eslint no-unused-vars by Trott · Pull Request #4536 · nodejs/node · GitHub

/ node Public

tools,test: enable eslint no-unused-vars - #4536

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:eslint-no-unused-vars
ConversationCommits (2)ChecksFiles changed
Closed

tools,test: enable eslint no-unused-vars#4536
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:eslint-no-unused-vars

Conversation

Trott commented Jan 5, 2016

Copy link
Copy Markdown
Member

No description provided.

Trott added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jan 5, 2016

Trott commented Jan 5, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1146/

rvagg commented Jan 5, 2016

Copy link
Copy Markdown
Member

so much copypasta in some of those test files

lgtm pending CI

targos commented Jan 5, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

cjihrig commented Jan 5, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Jan 5, 2016

Copy link
Copy Markdown
Member

CI failures look unrelated. LGTM

Trott added a commit that referenced this pull request Jan 5, 2016
test: remove unused vars
bc39d6a 
Remove unused vars in tests

PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Jan 5, 2016
tools: implement no-unused-vars for eslint
775cfdc 
PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Jan 5, 2016

Copy link
Copy Markdown
Member

Landed in bc39d6a and 775cfdc

jasnell closed this Jan 5, 2016
silverwind mentioned this pull request Jan 6, 2016
Closed
Fishrock123 mentioned this pull request Jan 6, 2016
Merged
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
test: remove unused vars
4b14f1c 
Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Conflicts:
	test/parallel/test-timers-throw-when-cb-not-function.js
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
tools: implement no-unused-vars for eslint
386030b 
PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins commented Jan 13, 2016

Copy link
Copy Markdown
Contributor

@Trott would you be able to manually backport this commit to v4.x?

MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
tools: implement no-unused-vars for eslint
31b6580 
PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 14, 2016
Closed
MylesBorins mentioned this pull request Jan 14, 2016
Merged

Trott commented Jan 14, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd Looks like this is now part of #4688 so I won't backport it myself. If that's a misunderstanding, let me know.

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
test: remove unused vars
7894f19 
Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
tools: implement no-unused-vars for eslint
ef5e9ef 
PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
test: remove unused vars
2f4538d 
Remove unused vars in tests

PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
tools: implement no-unused-vars for eslint
69fef19 
PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test: remove unused vars
30c3700 
Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
tools: implement no-unused-vars for eslint
9c2492d 
PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott deleted the eslint-no-unused-vars branch January 13, 2022 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL