FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Fix email for Ashley by mhdawson · Pull Request #45364 · nodejs/node · GitHub

/ node Public

doc: Fix email for Ashley - #45364

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
mhdawson:ash-email
Nov 8, 2022
Merged

doc: Fix email for Ashley#45364
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
mhdawson:ash-email

Conversation

mhdawson commented Nov 7, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Michael Dawson mdawson@devrus.com

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2022

mhdawson commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

@AshCripps FYI

AshCripps left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh thanks for this I didn't realise I had left this in.

Trott commented Nov 8, 2022

Copy link
Copy Markdown
Member

We'll want to add a .mailmap entry and update AUTHORS as well.

mhdawson and others added 2 commits November 7, 2022 18:47
Signed-off-by: Michael Dawson <mdawson@devrus.com>

Trott commented Nov 8, 2022

Copy link
Copy Markdown
Member

We'll want to add a .mailmap entry and update AUTHORS as well.

I did this and pushed the results in a fixup commit.

Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 8, 2022

github-actions Bot commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

This comment was marked as spam.

This comment was marked as resolved.

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2022
nodejs-github-bot merged commit 59938e3 into nodejs:main Nov 8, 2022

Copy link
Copy Markdown
Collaborator

Landed in 59938e3

RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
RafaelGSS mentioned this pull request Nov 10, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL