node-api: disambiguate napi_add_finalizer - #45401
Closed
legendecas wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
legendecas
force-pushed
the
node-api/add-finalizer
branch
from
77df31f to
c4d496b
Compare
November 10, 2022 16:48
mhdawson
reviewed
Dec 2, 2022
Comment thread
src/js_native_api_v8.cc
Outdated
mhdawson
reviewed
Dec 2, 2022
Comment thread
src/js_native_api_v8.cc
Outdated
mhdawson
approved these changes
Dec 2, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One small suggestion, but otherwise looks good to me.
Sorry, something went wrong.
legendecas
force-pushed
the
node-api/add-finalizer
branch
2 times, most recently
from
eaae589 to
ce5f9ab
Compare
December 5, 2022 16:17
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Dec 7, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@legendecas looks like this needs a rebase now. |
Sorry, something went wrong.
14 tasks
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call.
legendecas
force-pushed
the
node-api/add-finalizer
branch
from
ce5f9ab to
b04b070
Compare
December 20, 2022 03:01
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@mhdawson rebased. Would you mind taking a look again? thank you! |
Sorry, something went wrong.
This was referenced Dec 21, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
added a commit
that referenced
this pull request
Jan 4, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: nodejs#45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
toyobayashi
added a commit
to toyobayashi/emnapi
that referenced
this pull request
Jan 21, 2023
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
napi_add_finalizer doesn't support any operations related to
napi_wrap. Remove the ambiguous statements in the doc about
napi_wrap and avoid reusing the v8impl::Wrap call.