diagnostics_channel: built-in channels should remain experimental - #45423
Merged
nodejs-github-bot merged 1 commit intoNov 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
theanarkh
approved these changes
Nov 11, 2022
tony-go
approved these changes
Nov 11, 2022
Flarna
approved these changes
Nov 11, 2022
Flarna
reviewed
Nov 11, 2022
Comment thread
doc/api/diagnostics_channel.md
Outdated
Qard
force-pushed
the
built-in-diagnostics-channels-are-not-stable
branch
from
711bbfa to
361b728
Compare
November 14, 2022 18:42
RafaelGSS
approved these changes
Nov 14, 2022
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Qard
force-pushed
the
built-in-diagnostics-channels-are-not-stable
branch
from
361b728 to
d6a71bc
Compare
November 14, 2022 21:40
Copy link
Copy Markdown
Member
Author
|
I'm unclear why the markdown lint continues to fail. I see a bunch of warnings but no error messages yet it seems to fail for some reason. 🤔 |
Sorry, something went wrong.
legendecas
reviewed
Nov 15, 2022
Comment thread
src/node_contextify.cc
Outdated
Qard
force-pushed
the
built-in-diagnostics-channels-are-not-stable
branch
from
d6a71bc to
b407a4f
Compare
November 15, 2022 16:38
Flarna
approved these changes
Nov 15, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
PR-URL: #45423 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45423 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45423 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unintended side effect of stabilizing diagnostics_channel was that it was unclear that the built-in channels were not part of that stabilization. The built-in channels should be stabilized independently.
Fixes #45400
cc @nodejs/diagnostics