FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove flaky designation for test-worker-http2-stream-terminate by Trott · Pull Request #45438 · nodejs/node · GitHub

/ node Public

test: remove flaky designation for test-worker-http2-stream-terminate - #45438

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Trott:de-flaky
Nov 14, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: remove flaky designation for test-worker-http2-stream-terminate#45438
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Trott:de-flaky

Conversation

Trott commented Nov 12, 2022

Copy link
Copy Markdown
Member

Closes: #43084

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 12, 2022
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Nov 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47895/

Trott commented Nov 12, 2022

Copy link
Copy Markdown
Member Author

Stress test suggests this isn't flaky anymore, so I'm going to move this out of draft mode.

https://ci.nodejs.org/job/node-stress-single-test/378/

Trott marked this pull request as ready for review November 12, 2022 21:10
RafaelGSS approved these changes Nov 12, 2022
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

github-actions Bot mentioned this pull request Nov 13, 2022
Open
25 tasks
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 13, 2022
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47908/

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2022
github-actions Bot mentioned this pull request Nov 14, 2022
Open
25 tasks

ywave620 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Should we move this test back to parallel? I checked the CI history, after this test is moved to sequential, it has reliably paased in the last few months.

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 14, 2022
nodejs-github-bot merged commit badc631 into nodejs:main Nov 14, 2022

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in badc631

Trott deleted the de-flaky branch November 14, 2022 22:52
This was referenced Nov 15, 2022
Open
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
test: remove flaky designation for test-worker-http2-stream-terminate
00a3b5f 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
test: remove flaky designation for test-worker-http2-stream-terminate
314f10e 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
test: remove flaky designation for test-worker-http2-stream-terminate
85c634d 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test/parallel/test-worker-http2-stream-terminate.js

5 participants

Back | FazBrowse Home | New Git URL