events: refactor to use validator - #45448
Closed
Lxxyx wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
At least in theory, something that changes an error code is semver major so I added that label. But if others feel strongly that it isn't, I'm ok with it being removed and treating this as a bug fix. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I agree with @Trott. There might be some packages that depend on this error message, and therefore I'm good with semver-major label. |
Sorry, something went wrong.
aduh95
reviewed
Nov 13, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let's not validate the error messages.
Sorry, something went wrong.
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
aduh95
approved these changes
Nov 14, 2022
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Comment thread
test/parallel/test-event-emitter-max-listeners.js
Outdated
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 15, 2022
As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: nodejs#45448 (review)
jasnell
approved these changes
Nov 16, 2022
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM as a semver major. This should have a benchmark run before it lands.
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: #45448 (review) PR-URL: #45466 Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 24, 2022
As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: #45448 (review) PR-URL: #45466 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: #45448 (review) PR-URL: #45466 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: #45448 (review) PR-URL: #45466 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: #45448 (review) PR-URL: #45466 Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
This PR has conflicts that must be resolved |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use validateNumber() for events(setMaxListeners/defaultMaxListeners).
If passed wrong parameter types, validateNumber() will throw ERR_INVALID_ARG_TYPE instead of original error code: ERR_OUT_OF_RANGE. I think ERR_INVALID_ARG_TYPE is more accurate.