FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: patch V8 to 10.7.193.22 by targos · Pull Request #45460 · nodejs/node · GitHub

/ node Public

deps: patch V8 to 10.7.193.22 - #45460

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:v8-10.7.193.22
Nov 16, 2022
ConversationCommits (1)ChecksFiles changed
Merged

deps: patch V8 to 10.7.193.22#45460
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:v8-10.7.193.22

Conversation

targos commented Nov 14, 2022

Copy link
Copy Markdown
Member

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/v8-update

nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 14, 2022
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2022

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

anonrig commented Nov 15, 2022

Copy link
Copy Markdown
Member

@targos What is your timeline/thoughts for upgrading v8 11?

Trott commented Nov 15, 2022

Copy link
Copy Markdown
Member

You'll need to rebase against the main branch to pick up the fix for the lint issue.

targos commented Nov 15, 2022

Copy link
Copy Markdown
Member Author

Rebased

targos commented Nov 15, 2022

Copy link
Copy Markdown
Member Author

@anonrig Whenever it's ready. Note that there's nothing special to expect with V8 11.0 compared to other versions. V8 version numbers don't follow semver, they follow the Chromium schedule.

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47937/

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4986/

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4986/

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4986/

gengjiawen commented Nov 15, 2022

Copy link
Copy Markdown
Member

@targos What is your timeline/thoughts for upgrading v8 11?

You can try latest v8 bundled in node in https://github.com/nodejs/node-v8/tree/canary.

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47956/

nodejs-github-bot commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47962/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2022
nodejs-github-bot merged commit 8f9dc27 into nodejs:main Nov 16, 2022

nodejs-github-bot commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8f9dc27

This was referenced Nov 20, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
deps: patch V8 to 10.7.193.22
413bf9a 
Refs: v8/v8@10.7.193.20...10.7.193.22
PR-URL: #45460
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno mentioned this pull request Nov 24, 2022
Merged
targos deleted the v8-10.7.193.22 branch May 2, 2025 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
gengjiawen gengjiawen approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL