FazBrowse GitHub Viewer | Trending | | Home

Tools: [Download Repo ZIP] [Original HTTPS Page]

[v19.x backport] src,lib: group properties used as constants from `util` binding by daeyeon · Pull Request #45674 · nodejs/node · GitHub

[v19.x backport] src,lib: group properties used as constants from util binding - #45674

Closed

daeyeon wants to merge 2 commits into

nodejs:v19.x-stagingfrom

daeyeon:v19.x-staging.backport-45539

daeyeon commented Nov 29, 2022 •
edited
Loading

Copy link Copy Markdown

Member

Backports:

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v19.x labels Nov 29, 2022

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022

MoLow commented Nov 29, 2022

Copy link Copy Markdown

Member

why is backporting needed to v19?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022

This comment was marked as outdated.

Sign in to view

daeyeon commented Nov 29, 2022

Copy link Copy Markdown

Member Author

@MoLow #45539 (comment) It's requested. Guess it's useful for removing future conflicts upon the files changed on this patch.

targos commented Nov 29, 2022

Copy link Copy Markdown

Member

There's a chain of commits that depend on each other which started with #45125 (marked dont-land-on-v19.x).
It would probably be better to backport 066e77a first (can be done in the same PR).

joyeecheung and others added 2 commits November 29, 2022 23:17

util: use private symbols in JS land directly

18d9474

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: nodejs#45379
Backport-PR-URL: nodejs#45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

src,lib: group properties used as constants from util binding

f06e8e9

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#45539
Backport-PR-URL: nodejs#45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

daeyeon force-pushed the v19.x-staging.backport-45539 branch from 0567596 to f06e8e9 Compare November 29, 2022 14:19

daeyeon commented Nov 29, 2022

Copy link Copy Markdown

Member Author

@targos 066e77a is added also. PTAL

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

targos approved these changes Dec 5, 2022

View reviewed changes

github-actions Bot mentioned this pull request Dec 7, 2022

CI Reliability 2022-12-07 nodejs/reliability#450

Open

10 tasks

This comment was marked as outdated.

Sign in to view

github-actions Bot mentioned this pull request Dec 8, 2022

CI Reliability 2022-12-08 nodejs/reliability#451

Open

8 tasks

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

github-actions Bot mentioned this pull request Dec 9, 2022

CI Reliability 2022-12-09 nodejs/reliability#452

Open

5 tasks

nodejs-github-bot commented Dec 9, 2022

Copy link Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48363/

This was referenced Dec 10, 2022

CI Reliability 2022-12-10 nodejs/reliability#453

Open

CI Reliability 2022-12-11 nodejs/reliability#454

Open

CI Reliability 2022-12-12 nodejs/reliability#455

Open

daeyeon added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 12, 2022

daeyeon added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 12, 2022

targos pushed a commit that referenced this pull request Dec 12, 2022

util: use private symbols in JS land directly

8164a41

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

targos pushed a commit that referenced this pull request Dec 12, 2022

src,lib: group properties used as constants from util binding

b401800

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos commented Dec 12, 2022

Copy link Copy Markdown

Member

Landed in e8406a8...b401800

targos closed this Dec 12, 2022

github-actions Bot mentioned this pull request Dec 13, 2022

CI Reliability 2022-12-13 nodejs/reliability#456

Open

13 tasks

targos pushed a commit that referenced this pull request Dec 13, 2022

util: use private symbols in JS land directly

470384e

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

targos pushed a commit that referenced this pull request Dec 13, 2022

src,lib: group properties used as constants from util binding

2fbe2f9

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request Dec 30, 2022

util: use private symbols in JS land directly

3d2bef5

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request Dec 30, 2022

src,lib: group properties used as constants from util binding

2887220

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 3, 2023

util: use private symbols in JS land directly

3f18a83

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 3, 2023

src,lib: group properties used as constants from util binding

90e8418

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 5, 2023

util: use private symbols in JS land directly

2bd79a3

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 5, 2023

src,lib: group properties used as constants from util binding

b02b3c8

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Show hidden characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

targos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

Milestone

No milestone

Back | FazBrowse Home | New Git URL