test: move test file to sequential/ due to timing issues - #45722
Merged
aduh95 merged 1 commit intoMay 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/http @nodejs/testing |
Sorry, something went wrong.
Trott
approved these changes
Dec 3, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ShogunPanda
approved these changes
Aug 18, 2023
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Thanks!
Sorry, something went wrong.
mcollina
approved these changes
Aug 18, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This was referenced Aug 21, 2023
aduh95
force-pushed
the
move_test_to_run_sequentially
branch
from
6ae29c5 to
07fcb59
Compare
May 11, 2024 11:01
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#45722 Fixes: nodejs#43465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving test-http-server-request-timeouts-mixed from tests/parallel to tests/sequential
The flaky test is reproducible when we run tools/test.py -j96 --repeat=1024 test/parallel/test-http-server-request-timeouts-mixed.js. I tried tuning the timeouts at which the values are asserted, but they still seem to fail because of timing issues when the system is burdened.
As a workaround, I have moved the test to run sequentially(verified it with tools/test.py -j96 --repeat=128 test/sequential/test-http-server-request-timeouts-mixed.js)
Fixes: #43465