deps: update timezone to 2022g - #45731
Merged
nodejs-github-bot merged 1 commit intoDec 20, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Dec 4, 2022
RaisinTen
approved these changes
Dec 4, 2022
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
lpinca
approved these changes
Dec 4, 2022
richardlau
approved these changes
Dec 4, 2022
Copy link
Copy Markdown
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/45731 ✔ Done loading data for nodejs/node/pull/45731 ----------------------------------- PR info ------------------------------------ Title deps: update timezone to 2022g (#45731) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/timezone-update -> nodejs:main Labels author ready, needs-ci, dependencies Commits 1 - deps: update timezone to 2022g Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/45731 Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45731 Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 04 Dec 2022 00:24:05 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45731#pullrequestreview-1203589566 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45731#pullrequestreview-1203603739 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45731#pullrequestreview-1203617214 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45731#pullrequestreview-1203666017 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-12-04T05:47:43Z: https://ci.nodejs.org/job/node-test-pull-request/48291/ - Querying data for job/node-test-pull-request/48291/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3625304927 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I've noticed that https://unicode-org.atlassian.net/browse/ICU-22217 says this update needs CLDR changes -- @srl295 is that something we can/should be doing at the same time here? |
Sorry, something went wrong.
This was referenced Dec 7, 2022
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
@yumaoka ? |
Sorry, something went wrong.
jasnell
approved these changes
Dec 19, 2022
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #45731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated by tools/timezone-update.yml.
Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data
To test, build node off this branch & log the version of tz using