test_runner: refactor tap_parser to use more primordials - #45745
Merged
nodejs-github-bot merged 2 commits intoDec 11, 2022
Merged
test_runner: refactor tap_parser to use more primordials#45745nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MoLow
approved these changes
Dec 5, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Dec 5, 2022
VoltrexKeyva
reviewed
Dec 5, 2022
Comment thread
lib/internal/test_runner/tap_parser.js
Outdated
benjamingr
previously requested changes
Dec 6, 2022
benjamingr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Changes LGTM, "request changes"ing so no one lands this by mistake without benchmarks showing no regression.
If benchmarks were run - feel free to treat this "request changes" as a "lgtm"
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@benjamingr we don't have benchmarks for the test runner, and IMO robustness is much more important than performance for a test runner anyway. (also it seems unlikely to me that this change would impact perf by any significant manner, but I don't have any data to back this up) |
Sorry, something went wrong.
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Dec 6, 2022
This was referenced Dec 7, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
5 tasks
This was referenced Dec 10, 2022
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45745 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45745 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
PR-URL: nodejs/node#45745 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> (cherry picked from commit 7a42a206ac37d95060640b4812aaef32535937e1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.