test: remove flaky parallel/test-process-wrap test - #45806
Merged
nodejs-github-bot merged 1 commit intoDec 12, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up. Fixes: nodejs#45805
targos
approved these changes
Dec 10, 2022
richardlau
approved these changes
Dec 10, 2022
This comment was marked as outdated.
anonrig
approved these changes
Dec 10, 2022
cjihrig
approved these changes
Dec 10, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Dec 10, 2022
11 tasks
11 tasks
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up. Fixes: #45805 PR-URL: #45806 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up. Fixes: #45805 PR-URL: #45806 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up. Fixes: #45805 PR-URL: #45806 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up. Fixes: #45805 PR-URL: #45806 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up. Fixes: #45805 PR-URL: #45806 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an old test (added when switching from libev to libuv) that tests implementation details of the internal process_wrap bindings. That kind of thing doesn't need testing in this day and age, and since the test is flaky, simply remove it instead of sinking time in fixing it up.
Fixes: #45805