test: enable idlharness WebCryptoAPI WPTs - #45822
Merged
nodejs-github-bot merged 1 commit intoDec 13, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Dec 11, 2022
aduh95
approved these changes
Dec 11, 2022
11 tasks
daeyeon
approved these changes
Dec 12, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Dec 12, 2022
13 tasks
12 tasks
This was referenced Dec 15, 2022
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45822 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
This is breaking the jstests in v18.x /Users/juan/GitHub/node/test/common/wpt.js:548
throw new Error(
^
Error: Found 1 unexpected passes. Consider updating test/wpt/status/WebCryptoAPI.json for these files:
idlharness.https.any.js
at process.<anonymous> (/Users/juan/GitHub/node/test/common/wpt.js:548:15)
at process.emit (node:events:525:35)
Node.js v18.13.1-pre
Command: out/Release/node /Users/juan/GitHub/node/test/wpt/test-webcrypto.js
[08:21|% 100|+ 3785|- 1]: Done
Failed tests:
out/Release/node /Users/juan/GitHub/node/test/wpt/test-webcrypto.js
make: *** [jstest] Error 1
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the idlharness.https.any.js tests from WebCryptoAPI WPT to run, adding 73 new PASS tests and 9 acknowledged failures that I'll be dealing with on an ongoing basis.